30 - containerized local development #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elopment, plus improved README
bradh
reviewed
May 11, 2024
| @@ -144,7 +144,7 @@ | |||
| "package:update": "if git diff --name-only ORIG_HEAD HEAD | grep --quiet package.json; then echo 'UPDATE: package.json was updated, consider running yarn in your workspace root'; fi", | |||
| "perms": "chmod -R u+rwX,go+rX,go-w .", | |||
| "semantic-release": "semantic-release --dry-run", | |||
| "start-server": "light-server --serve ../../ --bind localhost --port 8282 --no-reload --open --quiet &", | |||
| "start-server": "light-server --serve ../../ --bind 0.0.0.0 --port 8282 --no-reload --open --quiet", | |||
| "stop-server": "run-script-os", | |||
There was a problem hiding this comment.
I guess this means the server is exposed on all networks in a non-container environment. That seems like it should at least be explicit in the documentation.
There was a problem hiding this comment.
I made a new script for running in a container and left the old one the same. good feedback
JoshNels
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
&that backgroundsnpm run container-start-serverfor containerized running0.0.0.0instead oflocalhostfor container execution