Skip to content

Commit

Permalink
fix(ng-select): isOpen is optional as noted in the README (#2322)
Browse files Browse the repository at this point in the history
Co-authored-by: Pavan Kumar Jadda <17564080+pavankjadda@users.noreply.github.com>
  • Loading branch information
sroucheray and pavankjadda committed Feb 5, 2024
1 parent 5549b67 commit 9b694ba
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ map: {
| loadingText | `string` | `Loading...` | no | Set custom text when for loading items |
| labelForId | `string` | `-` | no | Id to associate control with label. |
| [markFirst] | `boolean` | `true` | no | Marks first item as focused when opening/filtering. |
| [isOpen] | `boolean` | `-` | no | Allows manual control of dropdown opening and closing. `True` - won't close. `False` - won't open. |
| [isOpen] | `boolean` | `-` | no | Allows manual control of dropdown opening and closing. `true` - won't close. `false` - won't open. |
| maxSelectedItems | `number` | none | no | When multiple = true, allows to set a limit number of selection. |
| [hideSelected] | `boolean` | `false` | no | Allows to hide selected items. |
| [multiple] | `boolean` | `false` | no | Allows to select multiple items. |
Expand Down
2 changes: 1 addition & 1 deletion src/ng-select/lib/ng-select.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ export class NgSelectComponent implements OnDestroy, OnChanges, OnInit, AfterVie
@Input() @HostBinding('class.ng-select-taggable') addTag: boolean | AddTagFn = false;
@Input() @HostBinding('class.ng-select-searchable') searchable = true;
@Input() @HostBinding('class.ng-select-clearable') clearable = true;
@Input() @HostBinding('class.ng-select-opened') isOpen = false;
@Input() @HostBinding('class.ng-select-opened') isOpen?: boolean = false;

@Input()
get items() { return this._items };
Expand Down

0 comments on commit 9b694ba

Please sign in to comment.