Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a...
Checklist
Description
So I think that the reason these tests weren't passing before was due to the refactor making the
paths
intsconfig
out of date, they needed one else../
. Then I ran into a class of issues that's described in these GitHub issues while runningyarn run integration:consumer:ngc
:angular/vscode-ng-language-service#183
angular/angular#16382
I fixed that issue by changing
baseUrl
to be./
and now when I runyarn run integration:consumer:ngc
I don't get any errors.Sorry it took me so long to get to this @dherges!
Does this PR introduce a breaking change?