Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Jsx Integration Test #439

Conversation

KyleBastien
Copy link
Contributor

I'm submitting a...

[x] Bug Fix
[ ] Feature
[ ] Other (Refactoring, Added tests, Documentation, ...)

Checklist

  • Commit Messages follow the Conventional Commits pattern
    • A feature commit message is prefixed "feat:"
    • A bugfix commit message is prefixed "fix:"
  • Tests for the changes have been added

Description

So I think that the reason these tests weren't passing before was due to the refactor making the paths in tsconfig out of date, they needed one else ../. Then I ran into a class of issues that's described in these GitHub issues while running yarn run integration:consumer:ngc:

angular/vscode-ng-language-service#183
angular/angular#16382

I fixed that issue by changing baseUrl to be ./ and now when I run yarn run integration:consumer:ngc I don't get any errors.

Sorry it took me so long to get to this @dherges!

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@dherges
Copy link
Contributor

dherges commented Dec 25, 2017

@KyleMcNutt glad you figured out! Enjoy the christmas days!

@dherges dherges merged commit 5d6c95c into ng-packagr:test-enhance-integration Dec 25, 2017
@github-actions
Copy link

This PR has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

This action has been performed automatically by a bot.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants