Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extra_salmon_quant_args quote issue #1257

Open
kdivilov opened this issue Mar 11, 2024 · 1 comment
Open

extra_salmon_quant_args quote issue #1257

kdivilov opened this issue Mar 11, 2024 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@kdivilov
Copy link

Description of the bug

Setting --extra_salmon_quant_args "--noLengthCorrection" leads to the following error message:
The following invalid input values have been detected: * --extra_salmon_quant_args: expected type: String, found: Boolean (true)

I believe the reason for this error is that the quotes surrounding --noLengthCorrection are removed somewhere along the way. This is based on there being no quotes around it in the DEBUG nextflow.cli.Launcher line in the log file.

Command used and terminal output

No response

Relevant files

No response

System information

Nextflow version 23.10.0
nf-core/rnaseq 3.14.0
singularity

@kdivilov kdivilov added the bug Something isn't working label Mar 11, 2024
@drpatelh drpatelh added this to the 3.15.0 milestone May 13, 2024
@pmoris
Copy link

pmoris commented May 15, 2024

I just encountered this issue myself while working on a custom pipeline that uses the same extra_args option as the rnaseq pipeline. From what I can tell, the problem only appears when providing a single extra argument, but it works fine for multiple ones.

For example:

--fastp_extra_args '--trim_poly_x' # interpreted as --trim_poly_x: true at the nextflow level
--fastp_extra_args '--trim_poly_x -y' # both args are interpreted by fastp only

The modules.config entry for the FASTP module contains this line:

params.fastp_extra_args ?: ''

And the parameter was also made available in the nextflow.config file.

Single and double quotes appear to behave similarly.

All of the above applies to the CLI, I did not test the behaviour when using a params.yml file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants