Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pairing between sample and genome is ignored for demultiplexed reads (cDNA mode) #254

Open
nschan opened this issue Aug 31, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@nschan
Copy link

nschan commented Aug 31, 2023

Description of the bug

When providing several samples that should be mapped to different genomes in a samplesheet, the pairing between sample (group) and genome is ignored.

Expected behaviour:
Reads from each group are mapped to the genome provided in the same row in "fasta".

Actual behaviour:
The reads and genomes are matched in a different order, presumably based on when they pass through the pipeline.

Parameters:
protocol: 'cDNA'
skip_demultiplexing: true
skip_modification_analysis: true
skip_fusion_analysis: true

It would be helpful if this behaviour was mentioned in the documentation, since it is not really obvious from the samplesheet layout and seems to be even suggested in the "With demultiplexing" section of the Usage documentation

Command used and terminal output

No response

Relevant files

No response

System information

Nextflow version: nextflow 23.08.1-edge
Hardware: HPC
Executor: slurm
Container engine: charliecloud
OS: SUSE
Pipeline version: nanoseq v3.1.0

@nschan nschan added the bug Something isn't working label Aug 31, 2023
@nschan
Copy link
Author

nschan commented Sep 1, 2023

Actually, this turned out to be a problem with my samplesheet, sorry.

@nschan nschan closed this as completed Sep 1, 2023
@nschan nschan reopened this Jan 16, 2024
@nschan
Copy link
Author

nschan commented Jan 16, 2024

I would like to reopen the issue, since I do not think it is an issue with my samplesheet.
Rather, it seems like #nf-core/nanoseq/blob/master/subworkflows/local/align_minimap2.nf#L21 does cross genome and fastq channels, but as far as I understand PREPARE_GENOME does not return the sample name / meta in the ch_fastq #nf-core/nanoseq/blob/master/subworkflows/local/prepare_genome.nf#L29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant