Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Igv reports #5263

Merged
merged 3 commits into from Mar 20, 2024
Merged

Igv reports #5263

merged 3 commits into from Mar 20, 2024

Conversation

soulj
Copy link
Contributor

@soulj soulj commented Mar 19, 2024

PR checklist

Add nf-core module for the igv-reports tool.

Closes #2173

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@soulj soulj requested a review from a team as a code owner March 19, 2024 14:53
@soulj soulj requested review from Aratz and removed request for a team March 19, 2024 14:53
@telatin telatin self-assigned this Mar 19, 2024
Copy link
Contributor

@telatin telatin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this PR with docker, it passed.
I checked the output files in the .nf-test/ directory and versions.yaml is fine, and the HTML document looks ok.

I wonder if the name should be igv-reports as it is in bioconda (see [naming conventions[(https://nf-co.re/docs/contributing/modules)).
UPDATE The linter clearly does not allow to add punctuation marks... I wonder if we can make it clearer in the docs?

✅ LGTM (but I'm new, so I'll let someone else double check :) )

@leomrtns leomrtns added this pull request to the merge queue Mar 20, 2024
Merged via the queue into nf-core:master with commit 0c39191 Mar 20, 2024
11 checks passed
vlebars pushed a commit to vlebars/modules that referenced this pull request Mar 20, 2024
* add inital igvreports module

* add full input and tests

---------

Co-authored-by: Andrea Telatin <15690844+telatin@users.noreply.github.com>
jvfe added a commit to jvfe/modules that referenced this pull request Mar 20, 2024
* master:
  Added contrast limited adaptive histogram equalization module (nf-core#5268)
  Leviosam2 index (nf-core#5316)
  Add subworkflow mapAD (nf-core#5239)
  Remove AMRFinderPlus DB update on each invocation (nf-core#5232)
  Revert "add paths in output directive in cellranger cout module" (nf-core#5306)
  Revert "update kallistobustools count output list" (nf-core#5307)
  Igv reports (nf-core#5263)
  Remove unnecessary .view() in subworkflows/nf-core/vcf_phase_shapeit5 & tests/modules/nf-core/shapeit5/ligate/main.nf (nf-core#5280)
  Add wittyer as module (nf-core#5171)
  Bamstats (nf-core#4474)
  gatk4_asereadcounter add updated meta and nf-tests (nf-core#5164)
  4557 new module kaijumergeoutputs + stub Kraken2/Kraken2 (nf-core#5249)
  add cram/index support to bwamem2 (nf-core#5248)
  Add README to modules build with Docker (nf-core#4935)
  update paths for VEP (nf-core#5281)
  nf-test bases2fastq (nf-core#5272)
  Add module seqfu/stats (nf-core#5275)
jvfe added a commit to jvfe/modules that referenced this pull request Mar 20, 2024
* master:
  Added contrast limited adaptive histogram equalization module (nf-core#5268)
  Leviosam2 index (nf-core#5316)
  Add subworkflow mapAD (nf-core#5239)
  Remove AMRFinderPlus DB update on each invocation (nf-core#5232)
  Revert "add paths in output directive in cellranger cout module" (nf-core#5306)
  Revert "update kallistobustools count output list" (nf-core#5307)
  Igv reports (nf-core#5263)
  Remove unnecessary .view() in subworkflows/nf-core/vcf_phase_shapeit5 & tests/modules/nf-core/shapeit5/ligate/main.nf (nf-core#5280)
  Add wittyer as module (nf-core#5171)
  Bamstats (nf-core#4474)
  gatk4_asereadcounter add updated meta and nf-tests (nf-core#5164)
  4557 new module kaijumergeoutputs + stub Kraken2/Kraken2 (nf-core#5249)
  add cram/index support to bwamem2 (nf-core#5248)
  Add README to modules build with Docker (nf-core#4935)
  update paths for VEP (nf-core#5281)
  nf-test bases2fastq (nf-core#5272)
  Add module seqfu/stats (nf-core#5275)
  Added gt/gff3validator (nf-core#4718)
  Added liftoff (nf-core#5209)
tucano pushed a commit to tucano/modules that referenced this pull request Mar 20, 2024
* add inital igvreports module

* add full input and tests

---------

Co-authored-by: Andrea Telatin <15690844+telatin@users.noreply.github.com>
jennylsmith pushed a commit to RSC-RP/modules that referenced this pull request Mar 20, 2024
* add inital igvreports module

* add full input and tests

---------

Co-authored-by: Andrea Telatin <15690844+telatin@users.noreply.github.com>
alexnater pushed a commit to alexnater/nf-core-modules that referenced this pull request Mar 21, 2024
* add inital igvreports module

* add full input and tests

---------

Co-authored-by: Andrea Telatin <15690844+telatin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new module: igv-reports
3 participants