Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add module muse/sump #5629

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add module muse/sump #5629

wants to merge 7 commits into from

Conversation

famosab
Copy link
Contributor

@famosab famosab commented May 17, 2024 •
edited

PR checklist

Closes #5621

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@famosab famosab requested a review from a team as a code owner May 17, 2024 14:16
@famosab famosab requested review from vagkaratzas and removed request for a team May 17, 2024 14:16
@famosab famosab changed the title Add module muse/sump and Dockerfile Add module muse/sump May 17, 2024
@famosab famosab mentioned this pull request May 17, 2024
Open
17 tasks
@maxulysse
Copy link
Member

I would rather we fix https://bioconda.github.io/recipes/muse/README.html
And update it to use the latest versions in https://github.com/wwylab/MuSE

@famosab
Copy link
Contributor Author

famosab commented May 21, 2024

I opened a PR: bioconda/bioconda-recipes#47957

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vagkaratzas vagkaratzas Awaiting requested review from vagkaratzas vagkaratzas is a code owner automatically assigned from nf-core/nf-test

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Hackathon: May 2024
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new module: MuSE
2 participants
@famosab @maxulysse