Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please make --binning_map_mode group and --ancient-dna compatible features #572

Closed
winklerin opened this issue Feb 2, 2024 · 2 comments · Fixed by #602
Closed

Please make --binning_map_mode group and --ancient-dna compatible features #572

winklerin opened this issue Feb 2, 2024 · 2 comments · Fixed by #602
Assignees
Labels
enhancement New feature or request

Comments

@winklerin
Copy link

Description of feature

Dear nf-core/mag team,
I'm working on aDNA sequences and would like to coassemble them while having the functions for ancient DNA assembly activated. I get the following error:
Invalid combination of parameter '--binning_map_mode' and parameter '--ancient_dna'. Ancient DNA mode can only be executed with --binning_map_mode own. You supplied: --binning_map_mode group
Might be a rare case, but for my samples it makes sense to coassemble. Could you please make --binning_map_mode group and --ancient-dna compatible features?

@winklerin winklerin added the enhancement New feature or request label Feb 2, 2024
@jfy133
Copy link
Member

jfy133 commented Feb 3, 2024

Hi @winklerin I assign this to Maxime as he has the most knowledge of the aDNA workflow :)

@maxibor maxibor linked a pull request Mar 13, 2024 that will close this issue
3 tasks
@jfy133
Copy link
Member

jfy133 commented May 19, 2024

Done in PRs aboev

@jfy133 jfy133 closed this as completed May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants