Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nf-core download skips 'bowtie2 align' singularity image with container string parsing error #318

Open
rdwngs opened this issue Oct 18, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@rdwngs
Copy link

rdwngs commented Oct 18, 2022

Description of the bug

When attempting to download and install chipseq-2.0.0 with singularity containers, the 'bowtie2 align' image gives a container string parsing error. I noticed the container string in main.nf for this module has nested double quotes instead of internal single quotes - is it terminating early?

container "${ workflow.containerEngine == "singularity" && !task.ext.singularity_pull_docker_container ?
"https://depot.galaxyproject.org/singularity/mulled-v2-ac74a7f02cebcfcc07d8e8d1d750af9c83b4d45a:1744f68fe955578c63054b55309e05b41c37a80d-0" :
"quay.io/biocontainers/mulled-v2-ac74a7f02cebcfcc07d8e8d1d750af9c83b4d45a:1744f68fe955578c63054b55309e05b41c37a80d-0" }"

Command used and terminal output

nf-core download chipseq -c singularity

...
ERROR    Cannot parse container string in                                                                download.py:483
         'nf-core-chipseq-2.0.0/workflow/modules/nf-core/modules/bowtie2/align/main.nf':

             ${ workflow.containerEngine ==

         ⚠ Skipping this singularity image..

Relevant files

https://github.com/nf-core/chipseq/blob/master/modules/nf-core/modules/bowtie2/align/main.nf

System information

nextflow version 22.10.0.5826
nf-core version 2.6
HPC
Local executor
Singularity container engine
Redhat Linux 8.5
chipseq version 2.0.0

@rdwngs rdwngs added the bug Something isn't working label Oct 18, 2022
@isaacvock
Copy link

I am having the exact same problem with chipseq version 2.0.0 and nf-core download, and was wondering if there were any updates; very similar system information as in the original report, but here are my details:

nextflow version 22.10.4.5836
nf-core version 2.7.2
HPC
Local executor
Redhat Linux 7.9

@JoseEspinosa JoseEspinosa mentioned this issue Apr 18, 2023
4 tasks
@JoseEspinosa
Copy link
Member

this module has nested double quotes instead of internal single quotes - is it terminating early?

Yes you are right @rdwngs, the module is updated now in the dev branch and the image can be downloaded for running the dev branch. Thanks for reporting!

@MatthiasZepper
Copy link
Member

Sadly, downloading exactly this pipeline version that contains the affected module will not be possible to support with the current nf-core download, for reasons explained here.

Nextflow has received a new functionality nextflow inspect that does resolve the container correctly, but it will take a while until the whole codebase of nf-core download has been rewritten to use the outputs of inspect (Certainly not for version 2.10, possibly also not yet 2.11). Thus, I suppose, the next pipeline release will happen earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants