Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[export] Mismatch between default footer filters and Auspice sidebar filters #1409

Open
joverlee521 opened this issue Feb 8, 2024 · 1 comment

Comments

@joverlee521
Copy link
Contributor

Follow up to #1384 (comment)

Auspice has been updated to having sidebar filtering available for all node traits that are not continuous in nextstrain/auspice#1743 (not yet released). However in augur export v2, the default footer filters only use the colorings fields:

augur/augur/export_v2.py

Lines 539 to 542 in 4bf72f8

# if not specified in the config, include all boolean and categorical colorbys
potentials = {coloring["key"] for coloring in data_json['meta']["colorings"]
if coloring["type"] != "continuous" and coloring["key"] != 'gt'}
data_json['meta']['filters'] = list(potentials)

The default footer filters should probably be updated to include all node traits to match the Auspice sidebar filters.

@jameshadfield
Copy link
Member

Now that Auspice will expose all available (non-continous) traits as sidebar-filtering options, I'd propose we drop any default "filter" values from Augur and make it explicitly opt-in. I don't think there's any need to deprecate it / remove it, as it's useful to some people, but we can make the "metadata columns" setting more prominant in the docs & recommend that as the method to include non-colouring data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants