Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jq to dev dependency #1399

Open
joverlee521 opened this issue Jan 26, 2024 · 2 comments
Open

Add jq to dev dependency #1399

joverlee521 opened this issue Jan 26, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@joverlee521
Copy link
Contributor

Context

Prompted by #1384 (comment)

Improve testing experience by using jq to parse JSON files in functional tests, e.g.

TODO: Using jq woud be cleaner, but requires an extra dev dependency.
$ python3 -c 'import json, sys; print(json.load(sys.stdin)["nodes"]["PAN/CDC_259359_V1_V3/2015"]["date"])' < branch_lengths.json
2020-12-31

@joverlee521 joverlee521 added the enhancement New feature or request label Jan 26, 2024
@jameshadfield
Copy link
Member

It'd be great to have jq available in our environments. For me it's use is severely limited by its inability to parse large trees. As a tool specifically for "testing experience" this might not matter, but if we are to start including it in our environments I think it'd be the right time to fix that bug (by contibuting a patch to expose parsing depth as an argument, or maintaining a conda recipe with an incresed depth, or some other way).

@victorlin
Copy link
Member

Do you mean in our Nextstrain runtimes or dev environments? It's already available in the managed runtimes (docker, conda).

For the Augur dev environment, I don't see inability to parse large trees as a blocker. I think there are few (if any) tests with trees large enough to break jq, and for those cases, whatever's being used right now can stay as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants