Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pricing App #43

Merged
merged 12 commits into from
May 20, 2024
Merged

Add Pricing App #43

merged 12 commits into from
May 20, 2024

Conversation

nmisek
Copy link
Contributor

@nmisek nmisek commented May 10, 2024 •
edited

@nmisek nmisek marked this pull request as draft May 15, 2024 20:34
@nmisek nmisek marked this pull request as ready for review May 15, 2024 20:34
@nmisek nmisek changed the title DRAFT: Nmisek/add pricing app Add Pricing App May 15, 2024
@nmisek nmisek marked this pull request as draft May 16, 2024 12:47
@nmisek nmisek marked this pull request as ready for review May 16, 2024 12:47
@nmisek nmisek marked this pull request as draft May 16, 2024 13:03
@nmisek nmisek marked this pull request as ready for review May 16, 2024 13:03
sebastian-quintero
sebastian-quintero requested changes May 16, 2024
View reviewed changes
Copy link
Member

@sebastian-quintero sebastian-quintero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version comment is blocking. The rest of the comments are non-blocking.

.nextmv/golden/price-optimization-ampl/ampl_model.mod Outdated Show resolved Hide resolved
price-optimization-ampl/VERSION Outdated Show resolved Hide resolved
price-optimization-ampl/input.json Show resolved Hide resolved
@nmisek nmisek marked this pull request as draft May 20, 2024 15:10
@nmisek nmisek marked this pull request as ready for review May 20, 2024 15:11
@nmisek nmisek marked this pull request as draft May 20, 2024 15:20
@nmisek nmisek marked this pull request as ready for review May 20, 2024 15:20
sebastian-quintero
sebastian-quintero approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@sebastian-quintero sebastian-quintero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮 🌮 🌮

@nmisek nmisek merged commit a1920df into develop May 20, 2024
29 checks passed
@nmisek nmisek deleted the nmisek/add-pricing-app branch May 20, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-quintero sebastian-quintero sebastian-quintero approved these changes

@ryanjoneil ryanjoneil Awaiting requested review from ryanjoneil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nmisek @sebastian-quintero