Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5004 for NextGen #5791

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Conversation

rogin
Copy link

@rogin rogin commented May 20, 2023

Initial testing by @jonbartels showed promise. Should be unit testable, but none provided.

@jonbartels
Copy link
Contributor

Fixes #5004

@jonbartels
Copy link
Contributor

My testing notes:

A quick peek shows that channel IDs are ordered:

      <enabledChannelIds>
        <string>ae998ba0-dfa4-4408-a1c4-5dc14d52a088</string>
        <string>bf1f325b-e055-46d9-910f-2ae2e3bea41a</string>
        <string>23ae9d81-df20-4bf5-a9b5-3132ccde7c8a</string>
      </enabledChannelIds>

I created a channel and changed code template scopes, dependencies, enabled/disabled channels. A diff between server exports after these changes is MUCH easier to read:

➜ diff 2023-05-20\ Mirth\ Backup.xml 2023-05-20\ Mirth\ Backup.2.xml          
2c2
<   <date>2023-05-20 13:08:37</date>
---
>   <date>2023-05-20 13:09:22</date>
1191c1191
<       <revision>1</revision>
---
>       <revision>2</revision>
1193c1193
<         <time>1684602500152</time>
---
>         <time>1684602558403</time>
1199d1198
<         <string>ae998ba0-dfa4-4408-a1c4-5dc14d52a088</string>
1203c1202,1204
<       <disabledChannelIds/>
---
>       <disabledChannelIds>
>         <string>ae998ba0-dfa4-4408-a1c4-5dc14d52a088</string>
>       </disabledChannelIds>
1208c1209
<           <revision>1</revision>
---
>           <revision>2</revision>
1210c1211
<             <time>1684602500181</time>
---
>             <time>1684602558433</time>
1214a1216
>               <contextType>CHANNEL_DEPLOY</contextType>
1215a1218
>               <contextType>CHANNEL_UNDEPLOY</contextType>
1221a1225
>               <contextType>CHANNEL_ATTACHMENT</contextType>    

@kpalang
Copy link

kpalang commented Jun 15, 2023

I would also like to see this PR merged. The issue this PR solves creates a lot of unnecessary noise versioning systems.

@pladesma pladesma added triaged RS-8020 Internal-Issue-Created An issue has been created in NextGen's internal issue tracker labels Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal-Issue-Created An issue has been created in NextGen's internal issue tracker RS-8020 triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants