Skip to content

Commit

Permalink
Log router type during setup
Browse files Browse the repository at this point in the history
  • Loading branch information
rs committed Oct 7, 2023
1 parent f1eb217 commit ab5fc69
Show file tree
Hide file tree
Showing 10 changed files with 37 additions and 5 deletions.
4 changes: 4 additions & 0 deletions router/ddwrt/setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ func New() (*Router, bool) {
}, true
}

func (r *Router) String() string {
return "ddwrt"
}

func (r *Router) Configure(c *config.Config) error {
c.Listens = []string{"127.0.0.1:" + r.ListenPort}
r.ClientReporting = c.ReportClientInfo
Expand Down
1 change: 1 addition & 0 deletions router/detect_other.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
//go:build !linux
// +build !linux

package router
Expand Down
4 changes: 4 additions & 0 deletions router/edgeos/setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ func New() (*Router, bool) {
}, true
}

func (r *Router) String() string {
return "edgeos"
}

func (r *Router) Configure(c *config.Config) error {
c.Listens = []string{"127.0.0.1:" + r.ListenPort}
r.ClientReporting = c.ReportClientInfo
Expand Down
4 changes: 4 additions & 0 deletions router/generic/setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ func New() *Router {
return &Router{}
}

func (r *Router) String() string {
return "generic"
}

func (r *Router) Configure(c *config.Config) error {
c.Listens = []string{":53"}
return nil
Expand Down
4 changes: 4 additions & 0 deletions router/merlin/setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ func New() (*Router, bool) {
}, true
}

func (r *Router) String() string {
return "merlin"
}

func (r *Router) Configure(c *config.Config) error {
c.Listens = []string{"127.0.0.1:" + r.ListenPort}
r.ClientReporting = c.ReportClientInfo
Expand Down
4 changes: 4 additions & 0 deletions router/openwrt/setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ func New() (*Router, bool) {
}, true
}

func (r *Router) String() string {
return "openwrt"
}

func (r *Router) Configure(c *config.Config) error {
c.Listens = []string{"127.0.0.1:" + r.ListenPort}
r.ClientReporting = c.ReportClientInfo
Expand Down
3 changes: 3 additions & 0 deletions router/router.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,14 @@ package router

import (
"errors"
"fmt"

"github.com/nextdns/nextdns/config"
)

type Router interface {
fmt.Stringer

// Configure reads and changes c to match router's needs.
// Ran before listen.
Configure(c *config.Config) error
Expand Down
4 changes: 4 additions & 0 deletions router/synology/setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ func New() (*Router, bool) {
}, true
}

func (r *Router) String() string {
return "synology"
}

func (r *Router) Configure(c *config.Config) error {
if b, err := os.ReadFile("/etc/dhcpd/dhcpd.info"); err != nil || !bytes.HasPrefix(b, []byte(`enable="yes"`)) {
// DHCP is disabled, listen on 53 directly
Expand Down
4 changes: 4 additions & 0 deletions router/ubios/setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ func New() (*Router, bool) {
}, true
}

func (r *Router) String() string {
return "ubios"
}

func (r *Router) Configure(c *config.Config) error {
if dnsFilterEnabled() {
return fmt.Errorf(`UDM "Content Filtering" feature is enabled. Please disable it to use NextDNS.`)

Check failure on line 36 in router/ubios/setup.go

View workflow job for this annotation

GitHub Actions / Run Check

error strings should not end with punctuation or newlines (ST1005)
Expand Down
10 changes: 5 additions & 5 deletions run.go
Original file line number Diff line number Diff line change
Expand Up @@ -181,18 +181,18 @@ func run(args []string) error {
if c.SetupRouter {
r := router.New()
if err := r.Configure(&c); err != nil {
log.Errorf("Configuring router: %v", err)
log.Errorf("Configuring %s router: %v", r, err)
}
p.OnStarted = append(p.OnStarted, func() {
log.Info("Setting up router")
log.Infof("Setting up %s router", r)
if err := r.Setup(); err != nil {
log.Errorf("Setting up router: %v", err)
log.Errorf("Setting up %s router: %v", r, err)
}
})
p.OnStopped = append(p.OnStopped, func() {
log.Info("Restore router settings")
log.Infof("Restore %s router settings", r)
if err := r.Restore(); err != nil {
log.Errorf("Restore router settings: %v", err)
log.Errorf("Restore %s router settings: %v", r, err)
}
})
}
Expand Down

0 comments on commit ab5fc69

Please sign in to comment.