Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remotedesktop - remove onlyoffice from the list #2500

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

remotedesktop - remove onlyoffice from the list #2500

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0dceace
remotedesktop - remove onlyoffice from the list
szaimen May 27, 2023
e68e33f
Merge branch 'master' into enh/noid/remotedesktop-remove-onlyoffice
enoch85 May 28, 2023
0f1827f
Merge branch 'master' into enh/noid/remotedesktop-remove-onlyoffice
enoch85 Jan 15, 2024
0df9612
Merge branch 'master' into enh/noid/remotedesktop-remove-onlyoffice
enoch85 Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
39 changes: 1 addition & 38 deletions not-supported/remotedesktop.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,14 +153,6 @@ else
MAKEMKV_SWITCH=ON
fi

# OnlyOffice
if is_this_installed onlyoffice-desktopeditors
then
ONLYOFFICE_SWITCH=OFF
else
ONLYOFFICE_SWITCH=ON
fi

# Picard
if is_this_installed picard
then
Expand Down Expand Up @@ -206,7 +198,6 @@ $CHECKLIST_GUIDE" "$WT_HEIGHT" "$WT_WIDTH" 4 \
"Grsync" "(File sync)" "$GRSYNC_SWITCH" \
"MakeMKV" "(Rip DVDs and Blu-rays)" "$MAKEMKV_SWITCH" \
"Nautilus" "(File Manager)" "$NAUTILUS_SWITCH" \
"OnlyOffice" "(Open Source Office Suite)" "$ONLYOFFICE_SWITCH" \
"Picard" "(Music tagger)" "$PICARD_SWITCH" \
"Sound Juicer" "(Rip CDs)" "$SJ_SWITCH" \
"VLC" "(Play Videos and Audio)" "$VLC_SWITCH" \
Expand Down Expand Up @@ -262,7 +253,7 @@ case "$choice" in
as well as the gnome desktop." "$SUBTITLE"
if yesno_box_no "Do you want to do this?" "$SUBTITLE"
then
APPS=(evince eog firefox gedit grsync gnome-themes-extra makemkv-oss makemkv-bin nautilus onlyoffice-desktopeditors \
APPS=(evince eog firefox gedit grsync gnome-themes-extra makemkv-oss makemkv-bin nautilus \
picard sound-juicer vlc acpid gnome-shell-extension-dash-to-panel gnome-shell-extension-arc-menu gnome-session xrdp)
for app in "${APPS[@]}"
do
Expand Down Expand Up @@ -329,34 +320,6 @@ We will need to add a 3rd party repository to install it which can set your serv
*"Nautilus"*)
install_remove_packet nautilus Nautilus
;;&
*"OnlyOffice"*)
SUBTITLE="OnlyOffice"
if is_this_installed onlyoffice-desktopeditors
then
print_text_in_color "$ICyan" "Uninstalling $SUBTITLE"
apt-get purge onlyoffice-desktopeditors -y
apt-get autoremove -y
rm -f /etc/apt/sources.list.d/onlyoffice-desktopeditors.list
apt-get update -q4 & spinner_loading
print_text_in_color "$ICyan" "$SUBTITLE was successfully uninstalled."
else
msg_box "OnlyOffice Desktop Editors are open source but not existing in the Ubuntu repositories.
Hence, we will add a 3rd-party repository to your server \
to be able to install and update OnlyOffice Desktop Editors using the apt packet manager.
This can set your server under risk, though!" "$SUBTITLE"
if yesno_box_yes "Do you want to install OnlyOffice Desktop Editors nonetheless?" "$SUBTITLE"
then
print_text_in_color "$ICyan" "Installing $SUBTITLE"
apt-key adv --keyserver hkp://keyserver.ubuntu.com:80 --recv-keys CB2DE8E5
Copy link
Collaborator Author

@szaimen szaimen May 28, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe adding the key in recommended way via add_trusted_key_and_repo can fix this. Needs investigation

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use that function no matter what. The behavior is updated in 22.04, hence the function.

echo "deb https://download.onlyoffice.com/repo/debian squeeze main" \
> /etc/apt/sources.list.d/onlyoffice-desktopeditors.list
apt-get update -q4 & spinner_loading
install_if_not onlyoffice-desktopeditors
print_text_in_color "$ICyan" "$SUBTITLE was successfully installed"
fi
fi
unset SUBTITLE
;;&
*"Picard"*)
install_remove_packet picard Picard
;;&
Expand Down