add table_id index to oc_tables_columns #1078
Open
+31
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
juliushaertl
reviewed
May 8, 2024
|
One thing I missed when discussing this earlier, we should still add the indices to the existing migration files where the tables are created. That way the index is immediately there on new installations. |
grnd-alt
force-pushed
the
perf/add-table-id-index
branch
2 times, most recently
from
991fe38
to
3794252
Compare
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
grnd-alt
force-pushed
the
perf/add-table-id-index
branch
from
3794252
to
114cb8a
Compare
juliushaertl
reviewed
May 8, 2024
| @@ -59,6 +59,8 @@ public function changeSchema(IOutput $output, Closure $schemaClosure, array $opt | |||
| 'notnull' => false, | |||
| ]); | |||
| $table->setPrimaryKey(['id']); | |||
|
|
|||
| $table->addIndex(["ownership"]); | |||
There was a problem hiding this comment.
Would be good to also pass the index name as the second parameter
|
@grnd-alt @juliushaertl Why are we adding an index? |
|
To improve the performance of database queries that use those columns to filter for entries. |
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
grnd-alt
force-pushed
the
perf/add-table-id-index
branch
from
114cb8a
to
0d97014
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.