Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(faces): Fix call to Viewer.open #2468

Merged
merged 2 commits into from
May 13, 2024
Merged

fix(faces): Fix call to Viewer.open #2468

merged 2 commits into from
May 13, 2024

Conversation

marcelklehr
Copy link
Member

@marcelklehr marcelklehr requested a review from artonge May 8, 2024 09:58
@marcelklehr
Copy link
Member Author

/backport to stable29

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label May 8, 2024
@marcelklehr
Copy link
Member Author

/backport to stable28

fixes nextcloud/recognize#1109

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
Copy link
Member Author

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@marcelklehr marcelklehr merged commit 781a0e9 into master May 13, 2024
44 checks passed
@marcelklehr marcelklehr deleted the fix/faces-viewer branch May 13, 2024 17:02
@marcelklehr
Copy link
Member Author

/backport 544864a to stable29

@marcelklehr
Copy link
Member Author

/backport 544864a to stable28

@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label May 13, 2024
Copy link

backportbot bot commented May 13, 2024

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/2468/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 544864a

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2468/stable29

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/2468/stable29."}


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@marcelklehr
Copy link
Member Author

/backport 544864a to stable29

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label May 13, 2024
Copy link

backportbot bot commented May 13, 2024

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/2468/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 544864a5

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2468/stable29

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/2468/stable29."}


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-request Pending backport by the backport-bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot view pictures, stuck with waiting screen
3 participants