Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate App Store Description into English #1847

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

thgoebel
Copy link
Contributor

This PR fixes #1841 (F-Droid) and #1796 (Google Play).

  • Translate the app description into English.
  • Sync the features list in the full_description with the Readme's list.
  • Other minor edits to the Readme.

F-Droid should pickup the translation with the next app release.
With Google Play/Fastlane I am not 100% sure if/how Fastlane pushes these to Google Play. @stefan-niedermann could you please double-check this during the next release, that they are uploaded to Google Play?

@stefan-niedermann
Copy link
Member

@thgoebel The Nextcloud GmbH took over maintenance of the Notes Android app and I therefore do no longer have any control about release aspects.

Fastlane usually respects the translations and should the publish with the next release.

However, I am not sure whether this solution (a manual translation) is wanted or if Nextcloud GmbH wants to let the translations also handle by the Transifex Nextcloud community... There is a risc of outdated translations when changing the original text without having set up a proper translation pipeline.... 🤷‍♂️

@github-actions
Copy link

github-actions bot commented Aug 5, 2023

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@thgoebel
Copy link
Contributor Author

I searched around, and as far as I can see it's not straightforward to set up Transifex--Fastlane--integration. Right now I don't have more time to invest such integration. I'd prefer if someone from Nextcloud GmbH could do that. Also good for internal knowledge sharing so that they can do it for all apps, I guess.

So I'd leave it up to Nextcloud GmbH to decide whether

  1. they want to merge this as a quick fix (wie viele Nextcloud-Kunden sprechen schon Deutsch?) and later pull it upstream into Transifex, and setup the integration, or whether
  2. they don't want to merge this, fix it in Transifex, set up the integration, and then pull it down into Fastlane + into the Readme from Transifex.

@AndyScherzinger
Copy link
Member

@tobiasKaminsky and the team know more about it since I think the Files client uses fastlane and also makes use of transifex for app store text translations.

Fixes nextcloud#1841 (upon the next F-Droid release).
Fixes nextcloud#1796 (upon the next Fastlane sync to Play Store).

Signed-off-by: Thore Goebel <goebel.thore@gmail.com>
Now that Nextcloud Notes for Android is an official Nextcloud project
these points no longer apply.

Signed-off-by: Thore Goebel <goebel.thore@gmail.com>
@yurtpage
Copy link

The description was initially in English and German but in the commit by a mistake they were messed bf25ed5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

F-Droid app description - German-only, could consider translations
4 participants