Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: Issue #1259, Dismiss keyboard after changing the note title #1268

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update: Issue #1259, Dismiss keyboard after changing the note title #1268

wants to merge 2 commits into from

Conversation

ScottieKim
Copy link
Contributor

I made a correction for back button error in the main view with the drawer opened

stefan-niedermann
stefan-niedermann requested changes Jun 17, 2021
View reviewed changes
Copy link
Member

@stefan-niedermann stefan-niedermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the behavior is still the old when clicking on the grey backdrop outside of the dialog... Are you aware of any way to achieve the same behavior there, too?

app/src/main/java/it/niedermann/owncloud/notes/edit/title/EditTitleDialogFragment.java Outdated Show resolved Hide resolved
app/src/main/java/it/niedermann/owncloud/notes/edit/title/EditTitleDialogFragment.java Outdated Show resolved Hide resolved
app/src/main/java/it/niedermann/owncloud/notes/edit/title/EditTitleDialogFragment.java Outdated Show resolved Hide resolved
app/src/main/java/it/niedermann/owncloud/notes/edit/title/EditTitleDialogFragment.java Outdated Show resolved Hide resolved
@stefan-niedermann
Copy link
Member

@ScottieKim do you have a solution in case the dialog is dismissed by clicking on the backdrop as i noted above?

@AndyScherzinger
Copy link
Member

Rebased due to major technical updates in terms of libraries, especially AGP and SSO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefan-niedermann stefan-niedermann stefan-niedermann requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ScottieKim @stefan-niedermann @AndyScherzinger