Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: misplaced border ncselect #9491

Merged
merged 1 commit into from
May 27, 2024
Merged

Fix: misplaced border ncselect #9491

merged 1 commit into from
May 27, 2024

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Mar 21, 2024

Fix #9445

b a
image image

@GretaD
Copy link
Contributor

GretaD commented Mar 21, 2024

i thought the issue was that the dropdown not having a top border.

@hamza221
Copy link
Contributor Author

i thought the issue was that the dropdown not having a top border.

Yes, I realised that later after checking pre-vue8 , that's why I turned it into draft

Pre vue8 there was no border and no slot for no results

@hamza221
Copy link
Contributor Author

hamza221 commented Mar 21, 2024

pre vue-8
image

@hamza221 hamza221 marked this pull request as ready for review March 21, 2024 15:27
@hamza221
Copy link
Contributor Author

hamza221 commented Mar 21, 2024

I left the No result in
image

@hamza221 hamza221 requested a review from GVodyanov March 25, 2024 17:33
@ChristophWurst
Copy link
Member

/backport to stable3.6

@hamza221 hamza221 force-pushed the fix/partial-border-select branch 2 times, most recently from 91555c5 to d5bed81 Compare April 11, 2024 09:42
@hamza221
Copy link
Contributor Author

hamza221 commented Apr 11, 2024

PHP-CS unrelate to this PR, might be cause by this 7af56c9

@ChristophWurst
Copy link
Member

#9552

src/components/Composer.vue Outdated Show resolved Hide resolved
@GVodyanov GVodyanov self-requested a review April 18, 2024 17:48
GVodyanov
GVodyanov previously approved these changes Apr 18, 2024
Copy link
Contributor

@GVodyanov GVodyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!

Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when i setup an account for the first time and i have no search results, it is shown like this.
If i have at least one search result, it is shown correctly.

Screenshot from 2024-04-19 11-21-10

@ChristophWurst
Copy link
Member

The borderless design does not look very appealing. Could we fully switch to the default ncselect styling with borders? We have bordered and stacked inputs in other places too:
image

So I guess it would be fine to also have the borders in the Mail composer. @jancborchardt objections? if so, please provide mockups for a borderless select component

@GVodyanov GVodyanov self-requested a review April 22, 2024 14:11
@GVodyanov GVodyanov dismissed their stale review April 22, 2024 14:12

New suggestions from Christoph

@hamza221
Copy link
Contributor Author

@nextcloud/designers any suggestions?

Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to use our components as they natively look as @ChristophWurst suggests. Border-with will decrease to 1 pixel with the next release so they won't look as prominent.

If with time we realise that it's still too much, I would prefer finding a solution upstream, since these dense forms are ubiquitous in Nextcloud.

@hamza221 hamza221 requested a review from GretaD May 27, 2024 10:53
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
@hamza221 hamza221 enabled auto-merge May 27, 2024 12:40
@hamza221 hamza221 merged commit 7766fe3 into main May 27, 2024
34 checks passed
@hamza221 hamza221 deleted the fix/partial-border-select branch May 27, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Partial border for recipient select
5 participants