-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: misplaced border ncselect #9491
Conversation
i thought the issue was that the dropdown not having a top border. |
Yes, I realised that later after checking pre-vue8 , that's why I turned it into draft Pre vue8 there was no border and no slot for no results |
/backport to stable3.6 |
91555c5
to
d5bed81
Compare
PHP-CS unrelate to this PR, might be cause by this 7af56c9 |
d5bed81
to
b2c3542
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The borderless design does not look very appealing. Could we fully switch to the default ncselect styling with borders? We have bordered and stacked inputs in other places too: So I guess it would be fine to also have the borders in the Mail composer. @jancborchardt objections? if so, please provide mockups for a borderless select component |
@nextcloud/designers any suggestions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to use our components as they natively look as @ChristophWurst suggests. Border-with will decrease to 1 pixel with the next release so they won't look as prominent.
If with time we realise that it's still too much, I would prefer finding a solution upstream, since these dense forms are ubiquitous in Nextcloud.
12d336b
to
66cfc86
Compare
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
66cfc86
to
d4f159d
Compare
Fix #9445