Enh: Improve smart replies prompt #9426
Conversation
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
| return $replies; | ||
| $replies = $task->getOutput(); | ||
| $this->cache->addValue('smartReplies_'.$message->getId(), $replies); | ||
| return json_decode($replies, true); |
There was a problem hiding this comment.
open the code with phpstorm and let it fix the json_decode to throw on error ;-)
There was a problem hiding this comment.
and don't cache if you can't decode the replies. else the same decoding error happens again and again.
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
No description provided.