Bump max supported version. #846
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I submitted a similar PR for 2.15.1. See #742. Various tests were added at that time by @icewind1991. I tried to review those changes to see if there was anything I would need to add but I did not see anything and could not tell otherwise. I had copied the original PR from a prior version bump commit, and am simply doing the same here. I am just trying to get the dashboard not to complain about it being incompatible.
EDIT: As mentioned in icewind1991/files_markdown#219, the app is no longer opening there to edit the file. Instead markdown files are downloaded directly. Testing this, this also downloads the text file immediately rather than opening the editor. I will have to set up a dev environment to debug this further. This will not be as simple as #742.