Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix styling and move towards standard TemplateResponse #202

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Aug 19, 2020

  • Requires new RENDER_AS_CLEAN template on server that provide bare minimum styling (variables only) and core js

src/workersrc.js Outdated Show resolved Hide resolved
@jancborchardt

This comment has been minimized.

@szaimen

This comment has been minimized.

@skjnldsv

This comment has been minimized.

@rullzer rullzer mentioned this pull request Aug 27, 2020
21 tasks
@rullzer rullzer mentioned this pull request Sep 3, 2020
13 tasks
@szaimen

This comment has been minimized.

@skjnldsv

This comment has been minimized.

@skjnldsv skjnldsv modified the milestones: Nextcloud 20, Nextcloud 21 Sep 10, 2020
@jancborchardt
Copy link
Member

For reference, this is the small style modifications I experimented with – let’s see if they still work when we update pdf.js:

// Transparent background
body {
	background-color: transparent;
	background-image: none;
}

// Semi-transparent background for toolbars
#toolbarContainer,
.findbar,
.secondaryToolbar,
#toolbarSidebar {
	background-color: rgba(0, 0, 0, 0.85);
	background-image: none;
}

@szaimen

This comment has been minimized.

@skjnldsv

This comment has been minimized.

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In NC 20.0.0 pdf viewer uses unnecessary black bezels on the sides of a PDF document
3 participants