Tray menu right angle corner overlaps when pushed

[AHeimberger]

Hey guys, sorry but my eyes seem to be too good. The right button to open (Gallery, Data, Activity) overlaps the corner radius. Left button shows the expected behaviour, right button overlaps.

[er-vin]

Ah yes, good point, looks like there's a radius or a mask missing.

[AHeimberger]

Also Bottom List View Overlaps.

[DominiqueFuchs]

Indeed, search shows the simplifications introduced by be2e526 do not consider the case where the button (HeaderButton since that commit) is at the edge, e.g. having a rounded corner. Originally I implemented a (bulky but simple) custom background splitting that accommodates for that b/c Qt doesn't support rounding specific, single corners (still the case for the Account dropdown button on the left):

desktop/src/gui/tray/Window.qml

Lines 274 to 319 in cd91309

	background:
	Item {
	id: leftHoverContainer
	height: Style.trayWindowHeaderHeight
	width: Style.currentAccountButtonWidth
	Rectangle {
	width: Style.currentAccountButtonWidth / 2
	height: Style.trayWindowHeaderHeight / 2
	color: "transparent"
	clip: true
	Rectangle {
	width: Style.currentAccountButtonWidth
	height: Style.trayWindowHeaderHeight
	radius: Style.trayWindowRadius
	color: "white"
	opacity: 0.2
	visible: accountBtnMouseArea.containsMouse
	}
	}
	Rectangle {
	width: Style.currentAccountButtonWidth / 2
	height: Style.trayWindowHeaderHeight / 2
	anchors.bottom: leftHoverContainer.bottom
	color: "white"
	opacity: 0.2
	visible: accountBtnMouseArea.containsMouse
	}
	Rectangle {
	width: Style.currentAccountButtonWidth / 2
	height: Style.trayWindowHeaderHeight / 2
	anchors.right: leftHoverContainer.right
	color: "white"
	opacity: 0.2
	visible: accountBtnMouseArea.containsMouse
	}
	Rectangle {
	width: Style.currentAccountButtonWidth / 2
	height: Style.trayWindowHeaderHeight / 2
	anchors.right: leftHoverContainer.right
	anchors.bottom: leftHoverContainer.bottom
	color: "white"
	opacity: 0.2
	visible: accountBtnMouseArea.containsMouse
	}
	}

Not sure rn what should be best solution to this without reverting the component outsourcing made by @nicolasfella (i.e. one could again apply the workaround above for the apps button on the right, but this would render the HeaderButton component rather useless b/c it is used by one single button and we do not even have more space for possible future buttons)

Maybe someone comes up with a more clever/concise idea for the corner overlay.

[er-vin]

Well the problem at the bottom of the window that @AHeimberger points out was there before commit be2e526...

I'm wondering if we shouldn't remove everything related to the rounded corners in the inner components and only have the rounded corners obtained by clipping or a mask on the root element (this one would still be rounded obviously).

[DominiqueFuchs]

Well the problem at the bottom of the window that @AHeimberger points out was there before commit be2e526...

Yes I was only talking about the rounded corners here.

I'm wondering if we shouldn't remove everything related to the rounded corners in the inner components and only have the rounded corners obtained by clipping or a mask on the root element (this one would still be rounded obviously).

When you try this please note the current thin border of the window. This is merely visible in most cases but has it‘s reason for white (or whatever color the tray window background may have in the future) desktops.

[er-vin]

When you try this please note the current thin border of the window.

Yeah, I know it, remember I tuned the color in f147e5a. ;-)

This is merely visible in most cases but has it‘s reason for white (or whatever color the tray window background may have in the future) desktops.

The correct approach would use the outter rounded rectangle for clipping or masking, this would keep the border.

[AHeimberger]

Well, it is just a matter of taste, but I would be happy with corners. No radius. I guess you can not solve the radius with clipping. In my oppinion it is not a good first issue, it is a toth bitter issue.

[er-vin]

Well, it is just a matter of taste, but I would be happy with corners. No radius.

In fact me too (I even think there's a trend to move away from rounded containers), but I'm respecting the decisions taken before I was around. ;-)

I guess you can not solve the radius with clipping.

Good point, clipping areas are indeed rectangular, stupid me.

In my oppinion it is not a good first issue, it is a toth bitter issue.

Not sure what you meant here. It's a bit technical due to the mask but it won't involving a lot of code either. :-)