Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TrelloJsonService.php #5859

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update TrelloJsonService.php #5859

wants to merge 3 commits into from

Conversation

mulles
Copy link

@mulles mulles commented May 7, 2024 •
edited

Fixes the following issue: #5136 By fixing the following error when running 'php occ deck:import --system=TrelloJson'

Error: Call to a member function getUID() on string in /home/sites/site100028002/web/nextcloud.enklaave.org/apps/deck/lib/Service/Importer/Systems/TrelloJsonService.php:136

and

Error: Call to a member function getUID() on string in /home/sites/site100028002/web/nextcloud.enklaave.org/apps/deck/lib/Service/Importer/Systems/TrelloJsonService.php:364

Summary

TODO

  • ...

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@Apfelwurm
Copy link

Can confirm this fixes the Problem also for importing with the TrelloApi System. Thanks!

@mulles @juliushaertl
Update TrelloJsonService.php
c2425f3 
Fixes the following issue: nextcloud#5136
By fixing the following error when running 'php occ deck:import --system=TrelloJson'

Error: Call to a member function getUID() on string in /home/sites/site100028002/web/nextcloud.enklaave.org/apps/deck/lib/Service/Importer/Systems/TrelloJsonService.php:136

and 

Error: Call to a member function getUID() on string in /home/sites/site100028002/web/nextcloud.enklaave.org/apps/deck/lib/Service/Importer/Systems/TrelloJsonService.php:364


Signed-off-by: mulles <com.github@emu.lu>
@juliushaertl
Copy link
Member

/backport to stable29

@juliushaertl
Copy link
Member

/backport to stable28

@juliushaertl
Copy link
Member

/backport to stable27

@chkpnt
Copy link

chkpnt commented May 11, 2024

Can confirm this fixes the Problem also for importing with the TrelloApi System. Thanks!

I've just successfully imported a Trello-Board using TrelloApi after applying the proposed changes. Works fine. :-)

@github-actions GitHub Actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@mulles
Merge branch 'main' into patch-1
db4db8a
@mulles
Update TrelloJsonService.php
be26351 
removed trailing white space, I am sorry for that thx for your patience.

Signed-off-by: mulles <com.github@emu.lu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chkpnt chkpnt chkpnt approved these changes

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

Assignees
No one assigned
Labels
3. to review backport-request bug feedback-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trello JSON Import Error
5 participants
@mulles @Apfelwurm @juliushaertl @chkpnt @tflidd