-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: migrate to vite #3804
base: main
Are you sure you want to change the base?
perf: migrate to vite #3804
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3804 +/- ##
==========================================
- Coverage 2.44% 2.12% -0.32%
- Complexity 0 261 +261
==========================================
Files 90 114 +24
Lines 4541 5221 +680
Branches 1163 1130 -33
==========================================
Hits 111 111
- Misses 4310 4990 +680
Partials 120 120 ☔ View full report in Codecov by Sentry. |
d7a903a
to
c794d3d
Compare
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
c794d3d
to
e7f9d6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff
// TODO: uncomment once there are custom styles in the admin settings entrypoint | ||
// style('contacts', 'contacts-index'); | ||
// style('contacts', 'contacts-admin-settings'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
smells like dead code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can remove it again.
I just dropped a hint for a future maintainer that is wondering why custom styles won't work. In case we pimp the admin settings in the future.
Bundle sizes