-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script to template in order to bump app versions #957
base: master
Are you sure you want to change the base?
Conversation
I suggest to implement this in GitHub Actions, when owner of app push tag - replace with commit automatically those versions. |
Adding a github action could be done as an add-on. This structure was designed to allow custom scripts to be added easily without much effort. Running these scripts from a GH action is no big deal. This would allow the authors to disable the GH action though (makes not much sense, I have to admit). I can provide an implementation (after making it mergable) for that if that would be accepted and merged. Though, I do not want to work for nothing (aka the PR be rejected in the end). Therefore I am asking before investing too much and on too many details. |
If you could add entry for this to the Makefile(for example: Name of makefile command can be any that you choose. |
This needs manual documentation in the dev documentation. It makes however no sense to add this to the docs unless the scrips are rolled out in the app template. Signed-off-by: Christian Wolf <github@christianwolf.email>
161d580
to
c6f96f7
Compare
Make dows not allow for arbitrary parameters. (All parameters are interpreted as Make targets.) I could pass it via env variable (that would be like I personally prefer the env var variant as it seems cleaner. Do you consent, @bigcat88? |
Yep, I am totally fine with this, if it will work through env like you suggested. |
Let know when this is ready to merge |
This set of scripts should allow the developer to bump the version of the app to a new version. It will update the
appinfo/info.xml
and thepackage.json
file with the first CLI parameter.By adding custom scripts to the appropriate folder, it is possible to update other files automatically as well.
There is a topic in the forum that poses some general questions that might be correlated with this PR.