Add visual hint to collapsible headers in uploads tab #12847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasMayerDev
force-pushed
the
Feature/Add-collabsable-icon-in-uploads-tab
branch
from
863cabc
to
b0d9bb4
Compare
|
Does anyone know if that change in the license header is the right procedure when modifying the material icon? @alperozturk96 @tobiasKaminsky @ZetaTom |
nimishavijay
requested changes
May 24, 2024
Signed-off-by: Jonas Mayer <jonas.a.mayer@gmx.net>
Signed-off-by: Jonas Mayer <jonas.a.mayer@gmx.net>
Signed-off-by: Jonas Mayer <jonas.a.mayer@gmx.net>
Signed-off-by: github-actions <github-actions@github.com>
alperozturk96
force-pushed
the
Feature/Add-collabsable-icon-in-uploads-tab
branch
from
6686aa9
to
4dd35a3
Compare
alperozturk96
approved these changes
May 24, 2024
|
blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12847-Screenshot-blue-Light-08-33 |
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12847.apk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dividers / headers in the upload tab are collapsible, but I think it is missing a visual hint that it is.
The fact that I only found out about that feature after countless hours in that view underlines my point :)
Current design
I just quickly added an icon for it
@nextcloud/designers what do you think? Is that icon ok?