Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SPDX header #12809

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add SPDX header #12809

wants to merge 1 commit into from

Conversation

AndyScherzinger
Copy link
Member

  • Tests written, or not not needed

@AndyScherzinger
Copy link
Member Author

Hi @starypatyk @AlvaroBrey @ezaquarii
sorry to bug you, but in an effort to add standardized SPDX license/copyright headers to the source files of Nextcloud Android Files I spotted some classes (not limited to the ones ion this PR I guess) that are mislabelled as GPL3+ instead of AGPL3+ as mentioned in the projects readme file. So I wanted to get your feedback if you are fine we changing it from GLP3+ to AGPL3+

Thanks in advance for a brief feedback and sorry to bother you.

@ezaquarii
Copy link
Collaborator

I'm ok.

@AndyScherzinger AndyScherzinger force-pushed the chore/noid/spdxHeader16 branch 5 times, most recently from 9e354ac to cc1fb58 Compare April 7, 2024 16:06
@AndyScherzinger AndyScherzinger mentioned this pull request Apr 8, 2024
Merged
1 task
@AndyScherzinger AndyScherzinger force-pushed the chore/noid/spdxHeader16 branch 2 times, most recently from 96bccde to 095d866 Compare April 9, 2024 13:52
@starypatyk
Copy link
Contributor

Sorry for delayed response - I have been travelling lately. Fine for me as well. 👍

@AndyScherzinger
Add SPDX header
88228de 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12809.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings7171
Errors33

SpotBugs

CategoryBaseNew
Bad practice6767
Correctness7272
Dodgy code345345
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness66
Performance5757
Security1919
Total576576

@github-actions GitHub Actions
Copy link

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@AlvaroBrey
Copy link
Member

I'm fine with this too, sorry for the late reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2. developing feedback-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AndyScherzinger @ezaquarii @starypatyk @AlvaroBrey