Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Crash Show Fragment During FileActivity Lifecycle Change #12793

Closed
wants to merge 2 commits into from
Closed

Fix Crash Show Fragment During FileActivity Lifecycle Change #12793

wants to merge 2 commits into from

Conversation

JonasMayerDev
Copy link
Collaborator

By Alper

  • Tests written, or not not needed

@JonasMayerDev JonasMayerDev linked an issue Apr 2, 2024 that may be closed by this pull request
Crash while viewing (and downloading) media (in the background) #12760
Open
4 tasks
@alperozturk96 alperozturk96 mentioned this pull request Apr 3, 2024
Closed
1 task
@alperozturk96 alperozturk96 self-assigned this Apr 4, 2024
@ZetaTom ZetaTom linked an issue May 17, 2024 that may be closed by this pull request
App crash #12970
Open
@JonasMayerDev
Fix by Alper
02c7ebe 
Signed-off-by: Jonas Mayer <jonas.a.mayer@gmx.net>
@JonasMayerDev JonasMayerDev force-pushed the bugfix/crash-on-fragment-show-on-file-activity-lifecycle-change-by-alper branch from 3d5102b to 02c7ebe Compare May 23, 2024 18:20
@alperozturk96 @ZetaTom
Update app/src/main/java/com/owncloud/android/ui/activity/FileActivit…
fe47473 
…y.java

Co-authored-by: Tom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: Alper Öztürk <67455295+alperozturk96@users.noreply.github.com>
@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings7171
Errors33

SpotBugs

CategoryBaseNew
Bad practice6464
Correctness6969
Dodgy code346346
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness66
Performance5757
Security1919
Total571571

@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12793.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@alperozturk96
Copy link
Collaborator

Duplication of #13037

This was unlinked from issues May 24, 2024
App crash #12970
Open
Crash while viewing (and downloading) media (in the background) #12760
Open
@github-actions GitHub Actions
Copy link

blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12793-Screenshot-blue-Light-10-35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZetaTom ZetaTom ZetaTom left review comments

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees

@alperozturk96 alperozturk96

Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JonasMayerDev @alperozturk96 @ZetaTom