Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use non nullable context for PreviewMediaFragment #12792

Merged
merged 1 commit into from May 13, 2024
Merged

Use non nullable context for PreviewMediaFragment #12792

merged 1 commit into from May 13, 2024

Conversation

JonasMayerDev
Copy link
Collaborator

PR by Alper

  • Tests written, or not not needed

@JonasMayerDev JonasMayerDev linked an issue Apr 2, 2024 that may be closed by this pull request
Java error when delete a photo from media #12409
Closed
4 tasks
@alperozturk96 alperozturk96 mentioned this pull request Apr 3, 2024
Closed
1 task
@alperozturk96 alperozturk96 self-assigned this Apr 4, 2024
@JonasMayerDev JonasMayerDev force-pushed the bugfix/not-attached-context-usage-in-preview-media-fragment-by-alper branch from 15b51ef to 93576fa Compare May 8, 2024 13:23
@JonasMayerDev @alperozturk96
Fix by Alper
7615d8e 
Signed-off-by: Jonas Mayer <jonas.a.mayer@gmx.net>
@alperozturk96 alperozturk96 force-pushed the bugfix/not-attached-context-usage-in-preview-media-fragment-by-alper branch from 93576fa to 7615d8e Compare May 10, 2024 06:54
@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12792.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings7272
Errors33

SpotBugs

CategoryBaseNew
Bad practice6666
Correctness7070
Dodgy code349349
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness66
Performance5757
Security1919
Total577577

@alperozturk96 alperozturk96 merged commit f88e754 into master May 13, 2024
21 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/not-attached-context-usage-in-preview-media-fragment-by-alper branch May 13, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alperozturk96 alperozturk96 alperozturk96 approved these changes

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

Assignees

@alperozturk96 alperozturk96

Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Java error when delete a photo from media
2 participants
@JonasMayerDev @alperozturk96