Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enable dailies for nextcloud 29 #2738

Merged
merged 2 commits into from
May 25, 2024

Conversation

Pilzinsel64
Copy link
Member

@Pilzinsel64 Pilzinsel64 commented May 7, 2024

Fix #2737

Leaving dailies for nextcloud 26 as they still get generated on nextcloud.

.github/spawn-dailies.sh Outdated Show resolved Hide resolved
@Pilzinsel64 Pilzinsel64 requested a review from pachulo May 8, 2024 03:06
@Pilzinsel64 Pilzinsel64 force-pushed the feat/29-dailies branch 2 times, most recently from 914e201 to ce6eb0a Compare May 16, 2024 06:51
@Pilzinsel64
Copy link
Member Author

Cleaned git history, so this should be fine now.

@Pilzinsel64 Pilzinsel64 mentioned this pull request May 16, 2024
@kyrofa
Copy link
Member

kyrofa commented May 24, 2024

Leaving dailies for nextcloud 26 as they still get generated on nextcloud.

Only 29, 28, and 27 are actually supported. Time to remove 26, I think. We need to update our release strategy page as well to reflect the current state of things.

@Pilzinsel64
Copy link
Member Author

Time to remove 26,

Yes Sir. Done!

(When creating this commit I just throught "why not, as long upstream is active" in first point. And it's simpler to add a commit instead of removing one. 🙃)

@Pilzinsel64 Pilzinsel64 requested review from kyrofa and pachulo and removed request for kyrofa and pachulo May 25, 2024 15:24
@Pilzinsel64
Copy link
Member Author

Rebased. Would be cool to get this in before we do a new release with nc28.

@Pilzinsel64 Pilzinsel64 mentioned this pull request May 25, 2024
9 tasks
.github/spawn-dailies.sh Outdated Show resolved Hide resolved
Copy link
Member

@kyrofa kyrofa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, but +1 overall.

@Pilzinsel64 Pilzinsel64 merged commit e59c05f into nextcloud-snap:develop May 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants