Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: add the backport action #2603

Closed
wants to merge 1 commit into from

Conversation

pachulo
Copy link
Member

@pachulo pachulo commented Nov 4, 2023

This comes from https://github.com/tibdex/backport
It works with labels and it should make backporting to old-but-still-supported nextcloud versions less manual.

This comes from https://github.com/tibdex/backport
It works with labels and it should make backporting
to old-but-still-supported nextcloud versions less manual.
@pachulo pachulo requested a review from kyrofa November 4, 2023 22:41
@@ -0,0 +1,26 @@
name: Backport
on:
pull_request_target:
Copy link
Member

@kyrofa kyrofa Nov 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooo, yeah gotta be careful with this one. I'll need to re-learn a few things to properly review.

The docs on tibdex/backport are pretty light: did you follow something to accomplish this? Do you know if backports open PRs, or do they just automatically cherry-pick?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you follow something to accomplish this?

Not really, just searched for the action to do this with most stars 😅

Do you know if backports open PRs, or do they just automatically cherry-pick?

As I understand it, it creates new PRs; check https://github.com/tibdex/backport/blob/main/src/backport.ts#L268

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, there's much more info in the GitHub Marketplace page of the App.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you have time to check this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gently ping @kyrofa

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pachulo don't wait for me, feel free to land and iterate as necessary.

Copy link

github-actions bot commented Jan 5, 2024

This pull request is stale because it has been without activity for 60 days. It will be closed after 7 more days of inactivity.

@github-actions github-actions bot added the Stale label Jan 5, 2024
@github-actions github-actions bot closed this Jan 12, 2024
@pachulo pachulo reopened this Jan 14, 2024
@pachulo pachulo added feature New feature or request and removed Stale labels Jan 14, 2024
Copy link

This pull request is stale because it has been without activity for 60 days. It will be closed after 7 more days of inactivity.

@github-actions github-actions bot added the Stale label Mar 21, 2024
@pachulo pachulo removed the Stale label Mar 28, 2024
Copy link

This pull request is stale because it has been without activity for 60 days. It will be closed after 7 more days of inactivity.

@github-actions github-actions bot added the Stale label May 28, 2024
@github-actions github-actions bot closed this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants