-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github: add the backport action #2603
Conversation
This comes from https://github.com/tibdex/backport It works with labels and it should make backporting to old-but-still-supported nextcloud versions less manual.
@@ -0,0 +1,26 @@ | |||
name: Backport | |||
on: | |||
pull_request_target: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooo, yeah gotta be careful with this one. I'll need to re-learn a few things to properly review.
The docs on tibdex/backport are pretty light: did you follow something to accomplish this? Do you know if backports open PRs, or do they just automatically cherry-pick?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you follow something to accomplish this?
Not really, just searched for the action to do this with most stars 😅
Do you know if backports open PRs, or do they just automatically cherry-pick?
As I understand it, it creates new PRs; check https://github.com/tibdex/backport/blob/main/src/backport.ts#L268
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, there's much more info in the GitHub Marketplace page of the App.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you have time to check this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gently ping @kyrofa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pachulo don't wait for me, feel free to land and iterate as necessary.
This pull request is stale because it has been without activity for 60 days. It will be closed after 7 more days of inactivity. |
This pull request is stale because it has been without activity for 60 days. It will be closed after 7 more days of inactivity. |
This pull request is stale because it has been without activity for 60 days. It will be closed after 7 more days of inactivity. |
This comes from https://github.com/tibdex/backport
It works with labels and it should make backporting to old-but-still-supported nextcloud versions less manual.