[Step2] 로또(자동) #705
Open
[Step2] 로또(자동) #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohgillwhan
requested changes
Jun 19, 2023
Comment on lines
+2
to
+3
| class Lotto(lottoNumbers: List<LottoNumber>) { | ||
| val lottoNumbers: List<LottoNumber> |
There was a problem hiding this comment.
정렬이라면 view의 로직이기에 init에서 제거하고, 생성자를 통해 lottoNumber를 상태로 정의하는건 어떨까요?
|
|
||
| init { | ||
| require(lottoNumbers.size == LOTTO_SIZE) | ||
| hasNoDuplicatedNumbers(lottoNumbers) |
| require(lottoNumbers.size == LOTTO_SIZE) | ||
| hasNoDuplicatedNumbers(lottoNumbers) | ||
|
|
||
| this.lottoNumbers = lottoNumbers.sortedBy { it.number } |
Comment on lines
+20
to
+31
| override fun equals(other: Any?): Boolean { | ||
| if (this === other) return true | ||
| if (other !is Lotto) return false | ||
|
|
||
| if (lottoNumbers != other.lottoNumbers) return false | ||
|
|
||
| return true | ||
| } | ||
|
|
||
| override fun hashCode(): Int { | ||
| return lottoNumbers.hashCode() | ||
| } |
| } | ||
|
|
||
| fun getSameNumberCount(lotto: Lotto): Int { | ||
| return (LOTTO_SIZE * 2) - (lottoNumbers + lotto.lottoNumbers).toSet().size |
There was a problem hiding this comment.
컴퓨팅 파워는 조금 더 들지라도, 조금 더 간단하게 작성할 수 있을까요?
| import org.junit.jupiter.api.assertThrows | ||
| import java.lang.RuntimeException | ||
|
|
||
| class LottoTest { |
There was a problem hiding this comment.
테스트코드 내부에 반복은 없애볼까요? 필요하다면 @ParameterizedTest를 사용해볼까요?
|
|
||
| // when | ||
| // then | ||
| Lotto.of(lottoNumbers) |
There was a problem hiding this comment.
생성을 했으니, 정말 넘겨준 파라미터로 잘 생성이 되었는지 검증도 해볼까요? 그것도 로직일거 같아요~
| val isSame = sameLotto1 == sameLotto2 | ||
|
|
||
| // then | ||
| assertThat(isSame).isEqualTo(true) |
Comment on lines
+18
to
+23
| assertThat(sut.lottoResults.size).isEqualTo(1) | ||
| assertThat(sut.lottoResults.first().lotto).isEqualTo(lotto) | ||
| assertThat(sut.lottoResults.first().winningLotto).isEqualTo(winningLotto) | ||
| assertThat(sut.lottoResults.first().sameNumberCount).isEqualTo(6) | ||
| assertThat(sut.lottoResults.first().reward).isEqualTo(LottoReward.WINNER_1ST) | ||
| assertThat(sut.totalPrize).isEqualTo(LottoReward.WINNER_1ST.prize.toMoney()) |
There was a problem hiding this comment.
여기서 생성자를 테스트 하는 코드도 조금은 보이네요! 테스트를 조금 더 분리해볼까요?
| return LottoRoundStatistics(lottos, winningLotto) | ||
| } | ||
|
|
||
| private fun newLotto() = lottoGenerator.generate() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 ~ 로또미션 완료해서 리뷰 요청드립니다.
바쁘신데 새벽에 리뷰요청 죄송합니다 ㅠ