Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Deltacode documentation as part of Skeleton upgrade #189

Merged
merged 1 commit into from Apr 3, 2023

Conversation

arnav-mandal1234
Copy link
Collaborator

@arnav-mandal1234 arnav-mandal1234 commented Mar 28, 2023

@arnav-mandal1234 arnav-mandal1234 changed the title Update documentation as part of Skeleton upgrade [WIP] Update documentation as part of Skeleton upgrade #188 Mar 28, 2023
@arnav-mandal1234 arnav-mandal1234 changed the title [WIP] Update documentation as part of Skeleton upgrade #188 [WIP] Update documentation as part of Skeleton upgrade Mar 28, 2023
@arnav-mandal1234 arnav-mandal1234 changed the title [WIP] Update documentation as part of Skeleton upgrade Update Deltacode documentation as part of Skeleton upgrade Mar 28, 2023

System Requirements
-------------------

- Hardware : DeltaCode will run best with a modern X86 processor and at least 1GB of RAM and
250MB of disk.
- Hardware : DeltaCode will run best with a modern X86 64 bits processor and at
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied this from scancode-toolkit.

 * Modify `docs/source/deltacode/comprehensive_installation.rst`.
 * Modify `docs/source/deltacode/development.rst`.
 * Modify `docs/source/index.rst`.
 * Modify `docs/source/deltacode/GSOC_2021_report.rst`.
 * Modify `README.rst`
 * Fixes nexB#188

Signed-off-by: Arnav Mandal <arnav.mandal1234@gmail.com>
Copy link
Contributor

@JonoYang JonoYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I left a suggestion.

<https://deltacode.readthedocs.io/en/latest/comprehensive_installation.html#docker-install>`_


Quick Start
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should be a sentence mentioning to run ./configure or ./configure --dev prior to running deltacode

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above section of Quick Start is Installation. It has all the installation guides and I have linked it to the documentation page. See: Development installation from source code using a git clone. Moreover, Quick Start section is to guide everyone on how to use Deltacode.

I have kept the structure same as scancode-toolkit. Let me know what do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see what you mean. That makes sense.

Copy link
Contributor

@JonoYang JonoYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for updating the doc!

<https://deltacode.readthedocs.io/en/latest/comprehensive_installation.html#docker-install>`_


Quick Start
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see what you mean. That makes sense.

@AyanSinhaMahapatra
Copy link
Member

LGTM!
Thanks ++ @arnav-mandal1234 , merging!

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 249b497 into nexB:develop Apr 3, 2023
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documentation after deltacode gets merge in scancode-toolkit
3 participants