New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Deltacode documentation as part of Skeleton upgrade #189
Conversation
522e062
to
7b457b0
Compare
|
||
System Requirements | ||
------------------- | ||
|
||
- Hardware : DeltaCode will run best with a modern X86 processor and at least 1GB of RAM and | ||
250MB of disk. | ||
- Hardware : DeltaCode will run best with a modern X86 64 bits processor and at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copied this from scancode-toolkit.
* Modify `docs/source/deltacode/comprehensive_installation.rst`. * Modify `docs/source/deltacode/development.rst`. * Modify `docs/source/index.rst`. * Modify `docs/source/deltacode/GSOC_2021_report.rst`. * Modify `README.rst` * Fixes nexB#188 Signed-off-by: Arnav Mandal <arnav.mandal1234@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I left a suggestion.
<https://deltacode.readthedocs.io/en/latest/comprehensive_installation.html#docker-install>`_ | ||
|
||
|
||
Quick Start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there should be a sentence mentioning to run ./configure
or ./configure --dev
prior to running deltacode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The above section of Quick Start
is Installation
. It has all the installation guides and I have linked it to the documentation page. See: Development installation from source code using a git clone
. Moreover, Quick Start
section is to guide everyone on how to use Deltacode.
I have kept the structure same as scancode-toolkit. Let me know what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see what you mean. That makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for updating the doc!
<https://deltacode.readthedocs.io/en/latest/comprehensive_installation.html#docker-install>`_ | ||
|
||
|
||
Quick Start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see what you mean. That makes sense.
LGTM! |
docs/source/deltacode/comprehensive_installation.rst
.docs/source/deltacode/development.rst
.docs/source/index.rst
.docs/source/deltacode/GSOC_2021_report.rst
.README.rst