Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEWRELIC-5370 Update versioned tests to support restify@9.0.0 #1418

Merged
merged 1 commit into from Nov 16, 2022
Merged

NEWRELIC-5370 Update versioned tests to support restify@9.0.0 #1418

merged 1 commit into from Nov 16, 2022

Conversation

jmartin4563
Copy link
Contributor

@jmartin4563 jmartin4563 commented Nov 16, 2022

Proposed Release Notes

  • Update our versioned tests to support Restify 9.0.0

Links

Closes NEWRELIC-5370
Release Notes
Migration Guide
Re-Routing with next() removal

Details

Two major changes that effected our tests

  1. If using a callback for definitions, the function signature MUST have req, res, and next (arity 3)
  2. Using next('my-route') to perform re-routing is no longer supported and has been removed

@jmartin4563 jmartin4563 added the dev:tests Indicates only changes to tests label Nov 16, 2022
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #1418 (2013fb0) into main (b1d69e9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1418   +/-   ##
=======================================
  Coverage   95.78%   95.78%           
=======================================
  Files         192      192           
  Lines       37487    37487           
  Branches       23       23           
=======================================
  Hits        35907    35907           
  Misses       1580     1580           
Flag Coverage Δ
esm-unit-tests-14.x 47.57% <ø> (ø)
esm-unit-tests-16.x 92.14% <ø> (ø)
esm-unit-tests-18.x 92.14% <ø> (ø)
integration-tests-14.x 76.83% <ø> (+0.01%) ⬆️
integration-tests-16.x 76.93% <ø> (ø)
integration-tests-18.x 76.93% <ø> (-0.01%) ⬇️
unit-tests-14.x 90.50% <ø> (ø)
unit-tests-16.x 90.57% <ø> (ø)
unit-tests-18.x 90.55% <ø> (ø)
versioned-tests-14.x 75.19% <ø> (ø)
versioned-tests-16.x 76.63% <ø> (ø)
versioned-tests-18.x ?

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@bizob2828 bizob2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple enough

@jmartin4563 jmartin4563 merged commit 9955843 into newrelic:main Nov 16, 2022
Node.js Engineering Board automation moved this from Needs PR Review to Done: Issues recently completed Nov 16, 2022
@jmartin4563 jmartin4563 deleted the NEWRELIC-5370-restify-tests branch November 16, 2022 16:35
This was referenced Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:tests Indicates only changes to tests
Projects
Node.js Engineering Board
  
Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants