Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce TOML support to keymap file loading #2659

Open
wants to merge 9 commits into
base: devel
Choose a base branch
from

Conversation

metalefty
Copy link
Member

I started TOMLification starting from keymap files. I confirmed that TOML loader is valid by comparing structures loaded by both loaders are identical.

Things done in this PR:

  • Put TOML keymap files converted from INI keymaps
  • Implement TOML loader
  • Test keymap structure loaded from INI and TOML are identical

Not done in this PR:

  • Switch to TOML keymap loader completely
  • Removing INI keymap loader and INI keymap files

Copy link
Member

@matt335672 matt335672 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the test program through valgrind to check for memory errors and found no significant problems. There's a small leak (mention below), but otherwise I'm fine with this. It's a good approach.

tests/xrdp/test_xrdp_keymap.c Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants