Use the same depends solver for nrn and crnrn #2864
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
pramodk
approved these changes
Apr 30, 2024
This comment has been minimized.
This comment has been minimized.
|
✔️ ff8a79b -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
✔️ 9e13cb4 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
|
✔️ af4bd6b -> Azure artifacts URL |
|
1uc
reviewed
May 6, 2024
| @@ -492,7 +492,7 @@ endforeach() | |||
|
|
|||
| # we can link to MPI libraries in non-dynamic-mpi build | |||
| if(NRN_ENABLE_MPI AND NOT NRN_ENABLE_MPI_DYNAMIC) | |||
| target_link_libraries(coreneuron-core PUBLIC ${MPI_CXX_LIBRARIES}) | |||
| target_link_libraries(coreneuron-core PUBLIC ${MPI_C_LIBRARIES}) | |||
There was a problem hiding this comment.
I seem to remember that it sometimes matters. When compiling as a C++ project, some implementations of MPI (I think OpenMPI on Ubuntu (or ArchLinux)) would rely on C++ functionality, even if we were only using the C API ourselves.
I think that's why we have:
https://github.com/BlueBrain/HighFive/blob/d51d6cc0c87737e5e2d68adfe297576161eae1a2/cmake/HighFiveConfig.cmake#L13-L16
auto-merge was automatically disabled
May 31, 2024 15:22
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.