Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimal control of Wong Wang model #257

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

lenasal
Copy link
Collaborator

@lenasal lenasal commented Jan 16, 2024

  • minor changes in model implementation for consistency with other models
  • full implementation of OC for WW model
  • test of OC for WW model

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (762456a) 91.14% compared to head (71dd400) 90.80%.
Report is 6 commits behind head on master.

Files Patch % Lines
neurolib/control/optimal_control/oc.py 61.54% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
- Coverage   91.14%   90.80%   -0.33%     
==========================================
  Files          65       67       +2     
  Lines        5189     5240      +51     
==========================================
+ Hits         4729     4758      +29     
- Misses        460      482      +22     
Flag Coverage Δ
unittests 90.80% <89.36%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lenasal lenasal self-assigned this Jan 17, 2024
neurolib/models/wc/timeIntegration.py Outdated Show resolved Hide resolved
@caglorithm
Copy link
Member

This became a pretty big change and is not out of scope for the PR. Just checking: Did you test the changed models to see if this breaks anything?

@lenasal
Copy link
Collaborator Author

lenasal commented Feb 15, 2024

I didn't test beyond the automatic tests. But since all notebooks and test files are checked, this should be the same as running them manually?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants