Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed Dmat_ndt as param set in timeIntegration file #234

Merged
merged 1 commit into from
May 2, 2023
Merged

removed Dmat_ndt as param set in timeIntegration file #234

merged 1 commit into from
May 2, 2023

Conversation

lenasal
Copy link
Collaborator

@lenasal lenasal commented Apr 24, 2023 •
edited by caglorithm

This PR removes params["Dmat_ndt"] = Dmat_ndt as a parameter from the FHN, Hopf, WC, WW models because Dmat_ndt is derived from lengthMat and is not a parameter that should be set by the user.

caglorithm
caglorithm approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@caglorithm caglorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jajcayn
jajcayn approved these changes May 2, 2023
View reviewed changes
Copy link
Collaborator

@jajcayn jajcayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:)

@caglorithm caglorithm merged commit e37fb9a into neurolib-dev:master May 2, 2023
5 of 6 checks passed
@lenasal lenasal deleted the remove_dmatndt_as_param branch May 2, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jajcayn jajcayn jajcayn approved these changes

@caglorithm caglorithm caglorithm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lenasal @jajcayn @caglorithm