Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace usage of dictionaries in format_gene_df #5

Open
bschilder opened this issue Jul 30, 2021 · 0 comments
Open

Replace usage of dictionaries in format_gene_df #5

bschilder opened this issue Jul 30, 2021 · 0 comments
Assignees
@bschilder
Labels
bug Something isn't working
Milestone
Publish orthogene...

Comments

@bschilder
Copy link
Collaborator

format_gene_df uses dictionaries (named lists) to create new col names. But this is problematic when there are many:many orthologs. Switch over to using some sort of dataframe/filtering strategy instead.

Also, provide a warning to users when gene_output is "dict" or "dict_rev" AND non121_strategy is not "dbs".
@bschilder bschilder self-assigned this Aug 1, 2021
@bschilder bschilder added the bug Something isn't working label Aug 1, 2021
@bschilder bschilder modified the milestones: Publish orthogene preprint, Publish orthogene manuscript Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschilder bschilder

Labels
bug Something isn't working
Projects
None yet
Milestone
Publish orthogene manuscript
Development

No branches or pull requests
1 participant
@bschilder