Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orthogene fails rcmdcheck when ape isn't installed #40

Open
willgearty opened this issue Apr 2, 2024 · 1 comment
Open

orthogene fails rcmdcheck when ape isn't installed #40

willgearty opened this issue Apr 2, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@willgearty
Copy link

willgearty commented Apr 2, 2024

ape is only in Suggests, but it is called here:

orthogene/R/prepare_tree.R

Lines 129 to 130 in bc242c5

tr <- ape::drop.tip(phy = tr,
tip = tr$tip.label[unmapped])

This is ultimately called in one of the examples for plot_orthogene():

#' orthotree <- plot_orthotree(species = c("human","monkey","mouse"))

If ape is not installed rcmdcheck then fails. We've encountered this when trying to run a reverse dependencies check for rphylopic: https://github.com/palaeoverse/rphylopic/actions/runs/8524983850/job/23352044794

This example should be skipped if ape is not installed. You should also probably have some sort of graceful failure if ape is not installed and the user runs a similar command.

@willgearty willgearty added the bug Something isn't working label Apr 2, 2024
@bschilder
Copy link
Collaborator

Thanks for reporting this @willgearty , I'll make a fix and push it to GH/Bioc!

@bschilder bschilder self-assigned this Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants