Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address limitations of consensus peak calling #98

Open
3 tasks
bschilder opened this issue Jun 14, 2022 · 0 comments
Open
3 tasks

Address limitations of consensus peak calling #98

bschilder opened this issue Jun 14, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@bschilder
Copy link
Collaborator

bschilder commented Jun 14, 2022

EpiCompare::compute_consensus_peaks() has some limitations currently:

  1. Only uses peak files as inputs. Potentially losing information compared to using raw files (bedgraph, bigwig, bam). We should do some benchmarking to see how accurate consensus peak calling is using these different levels of inputs.
  2. Does not retain key columns for computing percentiles (e.g.c("total_signal", "qValue", "Peak Score")). Thus the consensus peaks can't be used for precision-recall curves or correlations. Would be good to integrate some sort of aggregation procedure for these metrics.
  3. Assumes all peak files were called using the same methodology, but in reality can come from SEACR (stringent or relaxed), MACS2 (narrow or broad) using different hyperparameters. Would be useful to have a method to harmonize all different kinds of peaks, though this might be a bit beyond the scope of this particular function.

Note: nf-core/cutandrun seems to use a very simplistic consensus peak calling strategy with bedtools, which I think is just looking for overlap between peak files, perhaps analogous to compute_consensus_peaks(method="granges"). We may want to suggest some more robust alternative consensus peak calling strategies to the cutandrun pipeline authors.
@Al-Murphy mentioned that MACS2 may have a functionality like this. @SarahMarzi @KittyMurphy have used this in the past?

Note: can’t seem to find any reference to consensus peak calling in the SEACR paper or github:
https://github.com/FredHutch/SEACR/search?q=consensus
So unless they’re using different terminology, it doesn't seem this is part of the functionality of SEACR.

@bschilder bschilder self-assigned this Jun 14, 2022
@bschilder bschilder added the enhancement New feature or request label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants