[DRAFT] Update datasets to include download, dataset metaclass, dataset objects #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4e7
reviewed
Apr 23, 2024
| downloaded_files = os.listdir(test_data_dir) | ||
| for split in ['train','test']: | ||
| for res in [resolution, resolution*2]: | ||
| assert f"darcy_{split}_{res}.pt" in downloaded_files |
There was a problem hiding this comment.
Can we do something more than checking for existence? An MD5 check would be reassuring.
There was a problem hiding this comment.
The MD5 check happens in the course of downloading
Comment on lines
+12
to
+15
| # TODO @Jean: do you think there's a better name for this base class? | ||
| # i/o pairs of 'x', 'y' stored as .pt files, but the distinguishing feature of this dataset | ||
| # isn't the file format, it's the attributes in its data batches | ||
| class PTDataset: |
There was a problem hiding this comment.
re: better name
Could we reuse the old name "[Base]PDEDataset"?
There was a problem hiding this comment.
I might prefer PDEDataset too, let me see if I can easily turn Burger's into this form too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to #280: we previously discussed adding
torchvision-style dataset files that include the ability to download data for sample problems, e.g. Navier-Stokes or Darcy flow. This PR will add this functionality as well as:PTDatasetclassAt this stage it's very open to feedback. Would love to hear what people think of the spec so far/ideas for how to improve it!
Currently I have a working
DarcyDatasetthat pulls data from a Zenodo archive, linked here.