Better legacy failure warning #1570
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horheynm
previously approved these changes
Jan 30, 2024
bfineran
reviewed
Jan 30, 2024
src/deepsparse/pipeline.py
Outdated
Comment on lines
143
to
144
| _LOGGER.warning(f"Could not create v2 '{task}' pipeline, with error: {e}") | ||
| _LOGGER.warning(f"Attempting to create the legacy pipeline") |
There was a problem hiding this comment.
could we combine these to one string so only one message is logged?
There was a problem hiding this comment.
Yeah I just figured the error might be long. But I'll put it at the end, something like:
_LOGGER.warning(f"Could not create v2 '{task}' pipeline, attempting to create the legacy pipeline. V2 pipeline error: {e}")
There was a problem hiding this comment.
You can just do:
_LOGGER.warning(f"Could not create v2 '{task}' pipeline, with error: {e}. "
"Attempting to create the legacy pipeline")
There was a problem hiding this comment.
I think Luka meant the error will be long so the sentence might look weird in the console
There was a problem hiding this comment.
Yeah just in case
rahul-tuli
previously approved these changes
Jan 30, 2024
dbogunowicz
previously approved these changes
Jan 30, 2024
src/deepsparse/pipeline.py
Outdated
Comment on lines
143
to
144
| _LOGGER.warning(f"Could not create v2 '{task}' pipeline, with error: {e}") | ||
| _LOGGER.warning(f"Attempting to create the legacy pipeline") |
There was a problem hiding this comment.
You can just do:
_LOGGER.warning(f"Could not create v2 '{task}' pipeline, with error: {e}. "
"Attempting to create the legacy pipeline")
|
You can't have the word |
|
Oh, I see. What words are allowed? Can I say |
|
@ProExpertProg you're currently failing this test: Which checks for |
Single-line and removed `error` keyword
ProExpertProg
dismissed stale reviews from dbogunowicz and horheynm
via
974fb3d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case someone fails to create the V2 pipeline, I think it's helpful to print the error.