Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring and enhancing user-facing Backend and Configs docs #7404

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

Schefflera-Arboricola
Copy link
Contributor

@Schefflera-Arboricola Schefflera-Arboricola marked this pull request as ready for review April 10, 2024 18:25
Copy link
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

I like the brief descriptions of the backends and all the wording checks.
The reorg is harder for me to visualize by looking at the diff. So I have to view the full source and/or the html docs. They seem good too.

See more minor comments below.

doc/reference/backends.rst Outdated Show resolved Hide resolved
doc/reference/backends.rst Outdated Show resolved Hide resolved
networkx/utils/backends.py Outdated Show resolved Hide resolved
networkx/utils/backends.py Show resolved Hide resolved
networkx/utils/backends.py Outdated Show resolved Hide resolved
networkx/utils/backends.py Outdated Show resolved Hide resolved
networkx/utils/backends.py Outdated Show resolved Hide resolved
networkx/utils/backends.py Show resolved Hide resolved
networkx/utils/configs.py Outdated Show resolved Hide resolved
networkx/utils/configs.py Outdated Show resolved Hide resolved
Co-authored-by: Dan Schult <dschult@colgate.edu>
Co-authored-by: Dan Schult <dschult@colgate.edu>
Co-authored-by: Dan Schult <dschult@colgate.edu>
Co-authored-by: Dan Schult <dschult@colgate.edu>
Co-authored-by: Dan Schult <dschult@colgate.edu>
@Schefflera-Arboricola Schefflera-Arboricola marked this pull request as draft April 15, 2024 12:08
@Schefflera-Arboricola Schefflera-Arboricola marked this pull request as ready for review April 17, 2024 18:48
@dschult dschult added the Dispatching Related to dispatching and backend support label Apr 25, 2024
Copy link
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready to be merged. I don't see any specific questions yet to be resolved, and we can update the docs further in another PR.
Thanks @Schefflera-Arboricola !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dispatching Related to dispatching and backend support type: Documentation
Development

Successfully merging this pull request may close these issues.

None yet

2 participants