Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pydot tests when testing backends #7356

Merged
merged 1 commit into from Mar 20, 2024
Merged

Conversation

eriknw
Copy link
Contributor

@eriknw eriknw commented Mar 17, 2024

This at least partially addresses the errors in #7354. In particular, this fixes the pydot errors.

I don't know how to fix the agraph segfaults you see in #7354 @rossbar. You can work around them by removing pygraphviz from your environment.

Also, I don't think pytest-xdist has anything to do with these errors, but I like the idea of running the dispatch tests with pytest-xdist if it makes them faster.

@rossbar
Copy link
Contributor

rossbar commented Mar 19, 2024

Also, I don't think pytest-xdist has anything to do with these errors

I suspect it does, at least indirectly - I always run the test suite with xdist on all my machines and have never hit these problems with the un-dispatched tests. It's only when I add the NETWORKX_TEST_BACKEND=nx-loopback to the test invocation that I see the failures reported in #7354

Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks @eriknw !

@dschult dschult merged commit 53c0513 into networkx:main Mar 20, 2024
41 of 42 checks passed
@jarrodmillman jarrodmillman added this to the 3.3 milestone Mar 20, 2024
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants