Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make is_negatively_weighted dispatchable #7352

Merged
merged 1 commit into from Mar 20, 2024

Conversation

eriknw
Copy link
Contributor

@eriknw eriknw commented Mar 14, 2024

This function may be useful for backends (and is useful for nx-cugraph).

We may want to dispatch more functions in nx.classes.function after version 3.3 is released. is_negatively_weighted and other functions in this file are often plenty fast with the NetworkX implementation, but I think making these dispatchable becomes much more feasible and desirable once we have should_run (already in) and caching (coming soon 馃).

CC @rlratzel

@rossbar rossbar added type: Enhancements Dispatching Related to dispatching and backend support labels Mar 19, 2024
Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, thanks @eriknw !

Copy link
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dschult dschult merged commit e71bd8a into networkx:main Mar 20, 2024
44 of 45 checks passed
@jarrodmillman jarrodmillman added this to the 3.3 milestone Mar 20, 2024
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dispatching Related to dispatching and backend support type: Enhancements
Development

Successfully merging this pull request may close these issues.

None yet

4 participants