Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Cache graphs objects when converting to a backend #7345

Merged
merged 13 commits into from Mar 31, 2024
Merged

ENH: Cache graphs objects when converting to a backend #7345

merged 13 commits into from Mar 31, 2024

Commits on Mar 31, 2024

  1. Minimal PR to add cache dict to graphs and clear them

    @eriknw @MridulS
    eriknw authored and MridulS committed Mar 31, 2024
    Copy the full SHA
    45f583a View commit details
    Browse the repository at this point in the history

  2. Cache backend graph conversions

    @eriknw @MridulS
    eriknw authored and MridulS committed Mar 31, 2024
    Copy the full SHA
    2e32093 View commit details
    Browse the repository at this point in the history

  3. Don't use cache when testing backends

    @eriknw @MridulS
    eriknw authored and MridulS committed Mar 31, 2024
    Copy the full SHA
    91efb87 View commit details
    Browse the repository at this point in the history

  4. Better caching

    @eriknw @MridulS
    eriknw authored and MridulS committed Mar 31, 2024
    Copy the full SHA
    5b13e37 View commit details
    Browse the repository at this point in the history

  5. fix typo

    @eriknw @MridulS
    eriknw authored and MridulS committed Mar 31, 2024
    Copy the full SHA
    c16beda View commit details
    Browse the repository at this point in the history

  6. Don't be silly; be optimistic. Also, update comments

    @eriknw @MridulS
    eriknw authored and MridulS committed Mar 31, 2024
    Copy the full SHA
    5d5dec8 View commit details
    Browse the repository at this point in the history

  7. Add warning when using a cached value

    @eriknw @MridulS
    eriknw authored and MridulS committed Mar 31, 2024
    Copy the full SHA
    8c600ba View commit details
    Browse the repository at this point in the history

  8. Make caching more robust 

    - Enable caching to be disabled by setting `__networkx_cache__` to None (or delete it).
- Improve warning to say how to manually clear cache.
- Update some `_dispatchable` decorators that were discovered to mutate data.
- Make the residual Graph an implementation detail and not dispatchable.
- Improve dispatch tests that mutate input (but more still needs done).
    @eriknw @MridulS
    eriknw authored and MridulS committed Mar 31, 2024
    Copy the full SHA
    16d2608 View commit details
    Browse the repository at this point in the history

  9. Add config to control caching

    @eriknw @MridulS
    eriknw authored and MridulS committed Mar 31, 2024
    Copy the full SHA
    b9e4198 View commit details
    Browse the repository at this point in the history

  10. Use nx._clear_cache to clear the cache

    @eriknw @MridulS
    eriknw authored and MridulS committed Mar 31, 2024
    Copy the full SHA
    0e61825 View commit details
    Browse the repository at this point in the history

  11. Add note about config being global

    @eriknw @MridulS
    eriknw authored and MridulS committed Mar 31, 2024
    Copy the full SHA
    b65c7f1 View commit details
    Browse the repository at this point in the history

  12. Disable cache for maximum_branching internal graph

    @eriknw @MridulS
    eriknw authored and MridulS committed Mar 31, 2024
    Copy the full SHA
    ddfbd5c View commit details
    Browse the repository at this point in the history

  13. DRY

    @eriknw @MridulS
    eriknw authored and MridulS committed Mar 31, 2024
    Copy the full SHA
    7210b01 View commit details
    Browse the repository at this point in the history