Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #7339. shortest_path inconsisitent with warning #7341

Merged
merged 1 commit into from Mar 13, 2024
Merged

Fix #7339. shortest_path inconsisitent with warning #7341

merged 1 commit into from Mar 13, 2024

Conversation

eriknw
Copy link
Contributor

@eriknw eriknw commented Mar 11, 2024

The warning says the return type will change from dict to iterator in version 3.5. This PR changes the return type to dict, since we are not yet on version 3.5.

Please see #7339 for details. I think this will make main branch consistent and resolve the inconsistencies introduced in #6584 and #7161.

rossbar
rossbar approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does indeed make the behavior consistent with the current released version (3.2) and the FutureWarning.

Yet another piece of evidence that the shortest_path return types need another close inspection before the 3.3 release!

dschult
dschult approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dschult dschult merged commit e517554 into networkx:main Mar 13, 2024
41 of 42 checks passed
@jarrodmillman jarrodmillman added this to the 3.3 milestone Mar 13, 2024
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
@eriknw @cvanelteren
Fix networkx#7339. shortest_path inconsisitent with warning (networ…
6fd49b4 
…kx#7341)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschult dschult dschult approved these changes

@rossbar rossbar rossbar approved these changes

Assignees
No one assigned
Labels
type: Maintenance
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eriknw @dschult @rossbar @jarrodmillman